Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging manager on activation failure #1952

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Apr 18, 2024

Motivation

Same as #1920. This should be the last one, this time I actually looked through the code for similar cases.

@Earlopain Earlopain requested a review from a team as a code owner April 18, 2024 18:27
@andyw8 andyw8 added the bugfix This PR will fix an existing bug label Apr 19, 2024
@andyw8 andyw8 enabled auto-merge (squash) April 19, 2024 14:30
@vinistock vinistock added the vscode This pull request should be included in the VS Code extension's release notes label Apr 22, 2024
@andyw8 andyw8 merged commit 0580596 into Shopify:main Apr 22, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants