Avoid setting GEM_HOME and GEM_PATH for rbenv #1966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1947
Rbenv doesn't actually modify the GEM_HOME or GEM_PATH. It also doesn't add gem binary directories into the PATH. It follows a similar approach to ASDF by adding its
shims
directory into the PATH.Implementation
We can rely on the
env.PATH
returned by the activation script directly, without setting anything manually. That should be enough to find the gem executables.Automated Tests
Adapted our tests.