Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent debugger from printing to STDOUT #1968

Merged
merged 1 commit into from Apr 25, 2024

Conversation

vinistock
Copy link
Member

Motivation

The debugger and IRB sometimes print to stdout, which breaks the LSP communication with editors. We should prevent it from printing anything while we require the debugger.

Implementation

Started redirecting stdout to stderr until we finish requiring the debugger.

@vinistock vinistock added bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes labels Apr 24, 2024
@vinistock vinistock self-assigned this Apr 24, 2024
@vinistock vinistock requested a review from a team as a code owner April 24, 2024 20:51
@vinistock vinistock requested review from andyw8 and st0012 April 24, 2024 20:51
@vinistock vinistock merged commit 1639dd4 into main Apr 25, 2024
42 of 44 checks passed
@vinistock vinistock deleted the vs/prevent_debugger_from_printing branch April 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants