Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Sorbet sigs from docs #1998

Merged
merged 2 commits into from May 1, 2024
Merged

Remove Sorbet sigs from docs #1998

merged 2 commits into from May 1, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 1, 2024

As agreed with @vinistock and @st0012

@andyw8 andyw8 requested a review from a team as a code owner May 1, 2024 14:52
@andyw8 andyw8 requested review from st0012 and vinistock May 1, 2024 14:52
@andyw8 andyw8 mentioned this pull request May 1, 2024
Merged
@andyw8
Copy link
Contributor Author

andyw8 commented May 1, 2024

I also removed # frozen_string_literal: true since that seems unnecessary for code samples.

@andyw8 andyw8 added chore Chore task server This pull request should be included in the server gem's release notes labels May 1, 2024
@st0012 st0012 added the documentation Improvements or additions to documentation label May 1, 2024
@andyw8 andyw8 merged commit b97e2a0 into main May 1, 2024
41 of 42 checks passed
@andyw8 andyw8 deleted the andyw8/remove-sorbet-sigs-from-docs branch May 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
chore Chore task documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyw8 @st0012