Fix false positive in gem list matching #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
reviewed
May 3, 2024
vinistock
force-pushed
the
vs/fix_gem_list_matching
branch
from
e4b5893
to
f70a6d6
Compare
vinistock
force-pushed
the
vs/fix_gem_list_matching
branch
from
f70a6d6
to
9594ff5
Compare
dirceu
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our condition may incorrectly match if a gem like
ruby-lsp-railsis installed, butruby-lspisn't. We need to ensure that the list includes exactlyruby-lsp.Implementation
Started using a regex to match the gem name.