Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to feature list from editors docs #2078

Merged
merged 1 commit into from
May 27, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 22, 2024

Someone asked about where to find the list of available features. It would be awkward to maintain a list in the docs, but we can point people to the list in the code.

@andyw8 andyw8 added documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes labels May 22, 2024
@andyw8 andyw8 requested a review from a team as a code owner May 22, 2024 13:15
@andyw8 andyw8 requested review from st0012 and vinistock May 22, 2024 13:15
EDITORS.md Outdated
@@ -7,6 +7,9 @@ Code, use the official [Ruby LSP extension](https://marketplace.visualstudio.com
> Some Ruby LSP features may be unavailable or limited due to incomplete implementations of the Language Server
> Protocol, such as dynamic feature registration, or [file watching](https://github.com/Shopify/ruby-lsp/issues/1456).

If you need to select particular features to enable or disable, see the `run_initialize` method in
`[lib/ruby_lsp/server.rb](lib/ruby_lsp/server.rb) for the full list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of server.rb, would it be easier for people to look at the package.json configs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup we can do that, updated.

@andyw8 andyw8 force-pushed the andyw8/add-pointer-to-feature-list branch from 6f8aae0 to 82ca4f1 Compare May 27, 2024 19:34
@andyw8 andyw8 merged commit ae6aed3 into main May 27, 2024
33 checks passed
@andyw8 andyw8 deleted the andyw8/add-pointer-to-feature-list branch May 27, 2024 19:44
andyw8 added a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants