Add on type formatting completions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Aug 19, 2022
egiurleo
reviewed
Aug 22, 2022
vinistock
force-pushed
the
vs/add_on_type_formatting
branch
from
edce6de
to
0c66ed2
Compare
|
We didn't need the expectations test or the folder, so I removed it in the latest commits. |
egiurleo
approved these changes
Aug 25, 2022
st0012
approved these changes
Aug 25, 2022
andyw8
pushed a commit
to andyw8/ruby-lsp
that referenced
this pull request
Mar 2, 2024
…running_bundle_install Display progress when running bundle install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Please see Shopify/vscode-ruby-lsp#193.
Implementation
Add the new
onTypeFormattingrequest and handle automatically closing ends, pipes and string interpolations.Automated Tests
Included new tests.
Manual Tests
Please see Shopify/vscode-ruby-lsp#193.