Allow 'webmaster' for Naming/InclusiveLanguage #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcphillips
commented
Jan 24, 2022
| @@ -326,6 +326,7 @@ Naming/InclusiveLanguage: | |||
| - 'blob/master/' | |||
| - 'origin/master' | |||
| - 'mastercard' | |||
| - 'webmaster' | |||
There was a problem hiding this comment.
I opened up the definition of the class and validated that strings in the AllowedRegex list here are matched ignoring case. Which is what we want.
rafaelfranca
approved these changes
Jan 24, 2022
sambostock
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working through inclusive language violations in Shopify and have come across a number of the
masterpattern triggering on usages ofwebmaster. But that is triggering on things like references to "Webmaster tools" and URLs or emails containing "webmaster". All things we don't control, linking out or using external services.I'm not sure about this specific term. But I've gone through some references and have found nothing talking about "webmaster". So I'm arguing to allow it as we do for "mastercard".
Some docs: