Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "Avoid defensive programming" #394

Merged
merged 2 commits into from
May 26, 2022
Merged

Conversation

nunosilva800
Copy link
Contributor

Link to http://www.erlang.se/doc/programming_rules.shtml#HDR11 is broken and this bit might deserve some more explanation.

I think this is a great summary, but here are some other links / resources:

Link to http://www.erlang.se/doc/programming_rules.shtml#HDR11 is broken and this bit might deserve some more explanation.
@nunosilva800 nunosilva800 marked this pull request as ready for review May 25, 2022 11:23
@nunosilva800 nunosilva800 requested review from volmer, rafaelfranca and a team as code owners May 25, 2022 11:23
@tomstuart
Copy link
Contributor

I think the Wikipedia quote is good, but this might be a more controversial change than just fixing the link to point to the archived version of the same page, which says basically the same thing but in more detail. Let’s see what reviewers think!

@rafaelfranca
Copy link
Member

Thank you for improving this @nunosilva800. I think we should link to the web archive and also add the quote. Can you please make that change?

README.md Outdated Show resolved Hide resolved
@rafaelfranca rafaelfranca merged commit 742ad8c into main May 26, 2022
@rafaelfranca rafaelfranca deleted the nunosilva800-patch-1 branch May 26, 2022 15:52
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 31, 2022 19:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants