Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.39.0 to 1.41.0 #465

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 20, 2022

Bumps rubocop from 1.39.0 to 1.41.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.41

New features

Bug fixes

  • #11255: Fix an error for Style/RequireOrder when require with no arguments is put between require. (@​ydah)
  • #11273: Fix a false positive for Lint/DuplicateMethods when there are same alias_method name outside rescue or ensure scopes. (@​koic)
  • #11267: Fix an error for Style/RequireOrder when modifier conditional is used between require. (@​ydah)
  • #11254: Fix an error for Style/RequireOrder when require is a method argument. (@​koic)
  • #11266: Fix a false positive for Style/RedundantConstantBase when enabling Lint/ConstantResolution. (@​koic)
  • #11296: Fix an error for Lint/NonAtomicFileOperation when use file existence checks line break unless by postfix before creating file. (@​koic)
  • #11284: Fix an incorrect autocorrect for Style/WordArray when assigning %w() array. (@​koic)
  • #11299: Fix base_dir in TargetFinder#find_files(). (@​dukaev)
  • #11250: Fix an error for Style/GuardClause when a method call whose last argument is not a string is in the condition body. (@​ydah)
  • #11298: Fix Lint/SafeNavigationChain to correctly handle [] operator followed by save navigation and method chain. (@​fatkodima)
  • #11256: Fix an incorrect autocorrect for Style/HashSyntax when without parentheses call expr follows after multiple keyword arguments method call. (@​koic)
  • #11289: Correctly detect Rails version when using only parts of the framework, instead of the "rails" gem. (@​bdewater)
  • #11262: Fix an error for Style/IfUnlessModifier when the body is a method call with hash splat. (@​fatkodima)
  • #11281: Fix NoMethodError for Style/Documentation when a class nested under non-constant values. (@​arika)

Changes

  • #11306: Make Style/IfWithSemicolon aware of one line without else body. (@​koic)

RuboCop 1.40

New features

  • #11179: Add Style/RedundantConstantBase cop. ([@​r7kamura][])
  • #11205: Add --[no-]auto-gen-enforced-style CLI option. (@​ydah)
  • #11235: Add Style/RequireOrder cop. ([@​r7kamura][])
  • #11219: Make Style/SelectByRegexp aware of !~ method. (@​koic)
  • #11224: Add new cop Style/ArrayIntersect which replaces (array1 & array2).any? with array1.intersect?(array2), method Array#intersect? was added in ruby 3.1. ([@​KirIgor][])
  • #11211: Add autocorrect for Lint/AssignmentInCondition. ([@​r7kamura][])

Bug fixes

  • #5251: Fix loading of configuration in multi-file edge case. ([@​NobodysNightmare][])
  • #11192: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using a block argument. (@​ydah)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.41.0 (2022-12-20)

New features

  • #11305: Add new Style/RedundantDoubleSplatHashBraces cop. ([@​koic][])
  • #10812: New AllowMultilineFinalElement option for all LineBreaks cops. ([@​Korri][])
  • #11277: Add new Style/ConcatArrayLiterals cop. ([@​koic][])

Bug fixes

  • #11255: Fix an error for Style/RequireOrder when require with no arguments is put between require. ([@​ydah][])
  • #11273: Fix a false positive for Lint/DuplicateMethods when there are same alias_method name outside rescue or ensure scopes. ([@​koic][])
  • #11267: Fix an error for Style/RequireOrder when modifier conditional is used between require. ([@​ydah][])
  • #11254: Fix an error for Style/RequireOrder when require is a method argument. ([@​koic][])
  • #11266: Fix a false positive for Style/RedundantConstantBase when enabling Lint/ConstantResolution. ([@​koic][])
  • #11296: Fix an error for Lint/NonAtomicFileOperation when use file existence checks line break unless by postfix before creating file. ([@​koic][])
  • #11284: Fix an incorrect autocorrect for Style/WordArray when assigning %w() array. ([@​koic][])
  • #11299: Fix base_dir in TargetFinder#find_files(). ([@​dukaev][])
  • #11250: Fix an error for Style/GuardClause when a method call whose last argument is not a string is in the condition body. ([@​ydah][])
  • #11298: Fix Lint/SafeNavigationChain to correctly handle [] operator followed by save navigation and method chain. ([@​fatkodima][])
  • #11256: Fix an incorrect autocorrect for Style/HashSyntax when without parentheses call expr follows after multiple keyword arguments method call. ([@​koic][])
  • #11289: Correctly detect Rails version when using only parts of the framework, instead of the "rails" gem. ([@​bdewater][])
  • #11262: Fix an error for Style/IfUnlessModifier when the body is a method call with hash splat. ([@​fatkodima][])
  • #11281: Fix NoMethodError for Style/Documentation when a class nested under non-constant values. ([@​arika][])

Changes

  • #11306: Make Style/IfWithSemicolon aware of one line without else body. ([@​koic][])

1.40.0 (2022-12-08)

New features

  • #11179: Add Style/RedundantConstantBase cop. ([@​r7kamura][])
  • #11205: Add --[no-]auto-gen-enforced-style CLI option. ([@​ydah][])
  • #11235: Add Style/RequireOrder cop. ([@​r7kamura][])
  • #11219: Make Style/SelectByRegexp aware of !~ method. ([@​koic][])
  • #11224: Add new cop Style/ArrayIntersect which replaces (array1 & array2).any? with array1.intersect?(array2), method Array#intersect? was added in ruby 3.1. ([@​KirIgor][])
  • #11211: Add autocorrect for Lint/AssignmentInCondition. ([@​r7kamura][])

Bug fixes

  • #5251: Fix loading of configuration in multi-file edge case. ([@​NobodysNightmare][])
  • #11192: Fix a false positive for Lint/ParenthesesAsGroupedExpression when using a block argument. ([@​ydah][])
  • #11143: Fix RedundantCopDisableDirective errors when encountering several department comments. ([@​isarcasm][])
  • #11230: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with [] operator followed by method chain. ([@​koic][])
  • #11181: Fix pattern to match .tool-versions files that specify multiple runtimes. ([@​noelblaschke][])
  • #11239: Fix an incorrect autocorrect for Style/GuardClause when using heredoc as an argument of raise in branch body. ([@​koic][])
  • #11182: Fix an incorrect autocorrect for EnforcedShorthandSyntax: always of Style/HashSyntax with Style/IfUnlessModifier when using Ruby 3.1. ([@​koic][])
  • #11184: Fix an error for Lint/ShadowingOuterLocalVariable when a block local variable has same name as an outer until scope variable. ([@​koic][])

... (truncated)

Commits
  • 19d8feb Cut 1.41
  • 5545762 Update Changelog
  • c055b39 Make Style/IfWithSemicolon aware of one line without else body
  • 4661caf [Fix #11267] Fix an error for Style/RequireOrder when modifier conditional is...
  • 8d0f750 Mark as private for YARD
  • a143510 Allow extensions inject their defaults
  • 0732939 Add new Style/RedundantDoubleSplatBrackets cop
  • e41543d Fix Lint/SafeNavigationChain to correctly handle [] operator followed by ...
  • 2dc325c More rubocop optimizations
  • 6c7bec0 Merge pull request #11301 from fatkodima/memory_profiler-file
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.39.0 to 1.41.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.39.0...v1.41.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner December 20, 2022 18:45
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 20, 2022
@sambostock
Copy link
Contributor

I've enabled the following new cops, as they seem sane enough, and unlikely to have a huge impact.

- Style/ConcatArrayLiterals
- Style/RedundantConstantBase
- Style/RedundantDoubleSplatHashBraces
@sambostock sambostock force-pushed the dependabot/bundler/rubocop-1.41.0 branch from 2235529 to 0f5fe94 Compare December 20, 2022 19:03
@sambostock sambostock merged commit 98c6f4d into main Dec 20, 2022
@sambostock sambostock deleted the dependabot/bundler/rubocop-1.41.0 branch December 20, 2022 19:04
@Korri Korri mentioned this pull request Jan 2, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems January 2, 2023 16:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant