Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Style/OperatorMethodCall and release 2.11.1 #474

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Disable Style/OperatorMethodCall and release 2.11.1 #474

merged 2 commits into from
Jan 2, 2023

Conversation

Korri
Copy link
Contributor

@Korri Korri commented Jan 2, 2023

This rule is causing (at least one) syntax error in code by replacing:

T.unsafe(self).==(...)

by

T.unsafe(self) == (...)

Which is not valid ruby

@Korri Korri requested a review from a team as a code owner January 2, 2023 18:06
sambostock
sambostock reviewed Jan 2, 2023
View reviewed changes
rubocop-shopify.gemspec Outdated Show resolved Hide resolved
sambostock
sambostock approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@sambostock sambostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the rogue merge conflict markers. We can merge after that's fixed.

@Korri
Disable Style/OperatorMethodCall
846d1c7 
This is causing syntax errors with some weird calls like
`something.==(...)`
@sambostock sambostock merged commit c6b9582 into main Jan 2, 2023
@sambostock sambostock deleted the bump-2.11.1 branch January 2, 2023 18:15
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems January 2, 2023 18:17 Inactive
@andyw8 andyw8 mentioned this pull request Jan 3, 2023
Closed
@andyw8
Copy link
Contributor

andyw8 commented Jan 3, 2023

I've created an issue for this in RuboCop: rubocop/rubocop#11377

@sambostock
Copy link
Contributor

Fixed in rubocop/rubocop#11378

@sambostock sambostock mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambostock sambostock sambostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Korri @andyw8 @sambostock