Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Naming/InclusiveLanguage AllowedRegex #535

Merged
merged 1 commit into from
May 1, 2023

Conversation

sambostock
Copy link
Contributor

@sambostock sambostock commented May 1, 2023

  • Generalize to permitting all URLs, as they are generally out of the author's control (looks for %r{\w*://\S+}).
  • Continue explicitly permitting blob/master, and add tree/master, in case of schemeless URL (github.com/org/repo/blob/master/README)
  • Allow space between origin and master, in addition to /, to allow usage like git pull origin master.

@sambostock sambostock requested a review from a team as a code owner May 1, 2023 03:59
@github-actions github-actions bot added the config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops label May 1, 2023
@sambostock sambostock force-pushed the tweak-allowed-exclusive-language branch from f888d57 to a89593e Compare May 1, 2023 04:01
- Generalize to permitting all URLs, as they are generally out of the
  author's control (looks for `%r{\w*://\S+}`).
- Continue explicitly permitting `blob/master`, and add `tree/master`,
  in case of schemeless URL (`github.com/org/repo/blob/master/README`)
- Allow space between `origin` and `master`, in addition to `/`, to
  allow usage like `git pull origin master`.
@sambostock sambostock force-pushed the tweak-allowed-exclusive-language branch from a89593e to c5de6aa Compare May 1, 2023 04:06
@sambostock sambostock merged commit adad1af into main May 1, 2023
21 checks passed
@sambostock sambostock deleted the tweak-allowed-exclusive-language branch May 1, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config change Changes the Rubocop config by enabling, disabling, or reconfiguring one or many cops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants