Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gofork for encoding/asn1 to fix ASN errors during Kerberos authentication #1697

Merged
merged 1 commit into from
May 22, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 11, 2020

This reverts commit bfff38f.

Closes #1658

@kvch kvch requested a review from bai as a code owner May 11, 2020 11:44
@ghost ghost added the cla-needed label May 11, 2020
@kvch kvch force-pushed the revert-removing-for-of-asn1 branch from 4676717 to c033597 Compare May 12, 2020 11:12
@ghost ghost removed the cla-needed label May 12, 2020
@kvch
Copy link
Contributor Author

kvch commented May 12, 2020

Is there anyone who could help me with fixing the errors on the CI? Locally everything passes. Maybe @bai?

@bai
Copy link
Contributor

bai commented May 12, 2020

/cc @d1egoaz

@d1egoaz
Copy link
Contributor

d1egoaz commented May 22, 2020

I've re-run CI and it's working now, I think it was some Github issue

@d1egoaz d1egoaz merged commit b5764af into IBM:master May 22, 2020
@twmb
Copy link

twmb commented Jun 21, 2020

As mentioned in other issues/prs:

I suspect the reason this broke things is because the fork returned its own asn1.ObjectType, which the stdlib marshalled differently, since it was not a stdlib asn1.ObjectType.

To re-apply this patch, you would need to do asn1.ObjectType(gssapi.OIN(....

@twmb
Copy link

twmb commented Jun 21, 2020

Alternatively, since this is marshalling a constant slice, the result of the marshal could just be hardcoded into place ([6 9 42 134 72 134 247 18 1 2 2])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kerberos authentication fails to authorize client
4 participants