Update gems (#466)

Shopify · Jan 20, 2023 · 293a390 · 293a390
1 parent 1dab1fe
commit 293a390
Show file tree

Hide file tree

Showing 11 changed files with 42 additions and 36 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
diff --git a/gemfiles/rails.gemfile.lock b/gemfiles/rails.gemfile.lock
diff --git a/gemfiles/redis_4.gemfile.lock b/gemfiles/redis_4.gemfile.lock
diff --git a/gemfiles/redis_5.gemfile.lock b/gemfiles/redis_5.gemfile.lock
diff --git a/gemfiles/redis_client.gemfile.lock b/gemfiles/redis_client.gemfile.lock
diff --git a/test/adapters/grpc_test.rb b/test/adapters/grpc_test.rb
@@ -70,6 +70,7 @@ def test_rpc_server_with_operation
 
   def test_unavailable_server_opens_the_circuit
     GRPC::ActiveCall.any_instance.stubs(:request_response).raises(::GRPC::Unavailable)
+
     ERROR_THRESHOLD.times do
       assert_raises(::GRPC::Unavailable) do
         @stub.an_rpc(EchoMsg.new)
@@ -204,6 +205,7 @@ def test_bulkheads_tickets_are_working
       stub1 = build_insecure_stub(EchoStub)
       stub1.semian_resource.acquire do
         stub2 = build_insecure_stub(EchoStub, host: "0.0.0.1")
+
         stub2.semian_resource.acquire do
           assert_raises(GRPC::ResourceBusyError) do
             stub2.an_rpc(EchoMsg.new)

diff --git a/test/adapters/mysql2_test.rb b/test/adapters/mysql2_test.rb
@@ -54,6 +54,7 @@ def test_connection_errors_open_the_circuit
 
   def test_query_errors_does_not_open_the_circuit
     client = connect_to_mysql!
+
     (ERROR_THRESHOLD * 2).times do
       assert_raises(::Mysql2::Error) do
         client.query("ERROR!")

diff --git a/test/adapters/net_http_test.rb b/test/adapters/net_http_test.rb
@@ -111,6 +111,7 @@ def test_bulkheads_tickets_are_working
         http_1 = Net::HTTP.new(SemianConfig["toxiproxy_upstream_host"], SemianConfig["http_toxiproxy_port"])
         http_1.semian_resource.acquire do
           http_2 = Net::HTTP.new(SemianConfig["toxiproxy_upstream_host"], SemianConfig["http_toxiproxy_port"])
+
           http_2.semian_resource.acquire do
             assert_raises(Net::ResourceBusyError) do
               Net::HTTP.get(URI("http://#{SemianConfig["toxiproxy_upstream_host"]}:#{SemianConfig["http_toxiproxy_port"]}/"))
@@ -232,6 +233,7 @@ def test_custom_raw_semian_options_can_only_assign_once
     semian_configuration_proc = proc do |host, port|
       DEFAULT_SEMIAN_OPTIONS.merge(name: "#{host}_#{port}")
     end
+
     with_semian_configuration(semian_configuration_proc) do
       assert_raises(Semian::NetHTTP::SemianConfigurationChangedError) do
         Semian::NetHTTP.semian_configuration = semian_configuration_proc
@@ -320,6 +322,7 @@ def test_use_custom_configuration_to_combine_endpoints_into_one_resource
       with_server do
         open_circuit!
       end
+
       with_server(
         ports: [SemianConfig["http_port_service_a"], SemianConfig["http_port_service_b"]],
         reset_semian_state: false,

diff --git a/test/adapters/redis_client_test.rb b/test/adapters/redis_client_test.rb
@@ -94,6 +94,7 @@ def test_connection_reset_does_not_open_the_circuit
   def test_command_errors_does_not_open_the_circuit
     client = connect_to_redis!
     client.call("HSET", "my_hash", "foo", "bar")
+
     (ERROR_THRESHOLD * 2).times do
       assert_raises(RedisClient::CommandError) do
         client.call("GET", "my_hash")

diff --git a/test/adapters/redis_test.rb b/test/adapters/redis_test.rb
@@ -96,6 +96,7 @@ def test_connection_reset_does_not_open_the_circuit
   def test_command_errors_does_not_open_the_circuit
     client = connect_to_redis!
     client.hset("my_hash", "foo", "bar")
+
     (ERROR_THRESHOLD * 2).times do
       assert_raises(Redis::CommandError) do
         client.get("my_hash")

diff --git a/test/lru_hash_test.rb b/test/lru_hash_test.rb
@@ -172,8 +172,6 @@ def test_monotonically_increasing
         # At this point, the table looks like: [a, c, b, d, e]
         assert_equal(notification, payload[:size])
         assert_equal(3, payload[:examined])
-      else
-        assert_nil(true)
       end
     end