Merged
Conversation
Without doing this the GC could move the objects returned by rb_const_get and make Semian's globals point to unexpected objects on the heap.
Without using `extern` in the header file it was making multiple definitions of the same variable.
rafaelfranca
approved these changes
Oct 13, 2020
paracycle
approved these changes
Oct 13, 2020
pushrax
approved these changes
Oct 13, 2020
Contributor
pushrax
left a comment
pushrax
left a comment
There was a problem hiding this comment.
I feel like there must be quite a lot of code in the wild that has this bug...
Contributor
Yes, plenty of extensions have this issue. |
casperisfine
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without doing this the GC could move the objects returned by
rb_const_get and make Semian's globals point to unexpected objects on
the heap.
No tests here because usually compaction bugs are hard to trigger reliably. I'm trying to trigger them in #274 though. If it goes well maybe we should include that as a best-effort regression test.