-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid chaining duplicated semian identifiers in error messages #423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Is there anywhere in the repo where we're currently constructing an error from another error's message where this was a problem? Or is this just a future-proofing fix?
lib/semian.rb
Outdated
else | ||
super | ||
prefix = "[#{@semian_identifier}] " | ||
# When errors are created from other errors messages they might |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# When errors are created from other errors messages they might | |
# When errors are created from other errors' messages they might |
Or maybe singularize it?
# When errors are created from other errors messages they might | |
# When an error is created from another error's message it might | |
# already have a semian identifier in the message |
Not in the repo, but |
086b048
to
e568d32
Compare
I think it should be mentioned in Changelog as well. |
When errors are created from other errors messages they might already have a semian identifier in their message
e568d32
to
8f713e4
Compare
Done. |
When errors are created from other errors messages they might already have a semian identifier in their message