DEBUG mode broke tests #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
handle-exceptions-debug-message
branch
3 times, most recently
from
1d77500
to
90bc064
Compare
miry
requested review from
casperisfine,
a team,
jgaskins,
michaelnugent and
AbdulRahmanAlHamali
and removed request for
a team
miry
force-pushed
the
handle-exceptions-debug-message
branch
from
90bc064
to
6b7b445
Compare
casperisfine
approved these changes
Oct 17, 2022
| resource.acquire {} | ||
| end | ||
| assert_equal("semop() failed, errno: 22 (Invalid argument)", exception.message) |
There was a problem hiding this comment.
Generally speaking it's a good idea to use assert_includes or assert_match when testing error messages, because did_you_mean error_highlight etc might augment the error message.
In debug mode there is an unexpected exception for tests. THe function to print semaphores could not access to the resource and raise exception. The observability should not produces exceptions and ignore errors. ```shell $ DEBUG=1 bundle exec rake clean build $ DEBUG=1 bundle exec ruby -Itest test/resource_test.rb -n test_destroy [pid=1345][semian] semaphore values lock: 1, tickets: 0 configured: 0, registered workers: 0 [pid=1345][semian] semaphore values lock: 0, tickets: 0 configured: 0, registered workers: 1 F Finished in 0.001262s, 792.3403 runs/s, 792.3403 assertions/s. 1) Failure: TestResource#test_destroy [test/resource_test.rb:393]: [Semian::SyscallError] exception expected, not Class: <Semian::InternalError> Message: <"error getting value of SI_SEM_LOCK for sem 131097, errno: 22 (Invalid argument)"> ---Backtrace--- test/resource_test.rb:394:in `acquire' test/resource_test.rb:394:in `block in test_destroy' --------------- ``` Disable DEBUG mode for containers, as it is produced unreliable tests. In debug function handle exceptions, to not produces errors.
miry
force-pushed
the
handle-exceptions-debug-message
branch
from
6b7b445
to
f4e8120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode there is an unexpected exception for tests.
THe function to print semaphores could not access to the resource and raise exception.
The observability should not produces exceptions and ignore errors.
Solution
Disable DEBUG mode for containers, as it is produced unreliable tests.
In debug function handle exceptions, to not produces errors.