Tune examples to cover some cases #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould not be reached
miry
force-pushed
the
examples-improve
branch
from
30737d6
to
21ba76e
Compare
miry
requested review from
a team,
Eagerod,
neufeldtech and
chopify
and removed request for
a team
Eagerod
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update examples to limit expected expectations and mark lines that should not be reached.
Replaced some rescue to single errors, to not cover to many problems.
Add lines to bulkhead examples to make sure script finished with unsuccess,
if thread or fork got exception.
Extract changes from #441