Don't mark redis readonly errors #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanth96
force-pushed
the
ignore-readonly-errors
branch
16 times, most recently
from
308eeaa
to
b594d43
Compare
shanth96
force-pushed
the
ignore-readonly-errors
branch
from
b594d43
to
92a8d35
Compare
MatthewRBruce
approved these changes
May 1, 2023
Mangara
approved these changes
May 1, 2023
casperisfine
approved these changes
May 2, 2023
miry
approved these changes
May 2, 2023
|
@shanth96 Pls update Changelog as well. I am going to include this change in v1.19.0 version. |
shanth96
force-pushed
the
ignore-readonly-errors
branch
4 times, most recently
from
59c0252
to
202957e
Compare
shanth96
force-pushed
the
ignore-readonly-errors
branch
from
202957e
to
ee459e3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Semians are triggered when a Redis is failed over. As the current primary gets switched over, it could take some time before clients realize the new redis primary. Until then, clients receive
READONLYerrors as they try to write against a ReadOnly replica.We shouldn't track these types of errors for semians since this is a fast failure and we'd want the clients to reconnect to the new primary ASAP.
This PR sets
marks_semian_circuits?to false for the ReadOnly errors from the two Redis clients.