Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.18.1 #490

Merged
merged 1 commit into from
May 2, 2023
Merged

Release v0.18.1 #490

merged 1 commit into from
May 2, 2023

Conversation

adrianna-chang-shopify
Copy link
Contributor

Cuts a new release with change from #486.
This will allow us to remove the dependency on the external adapter from Shopify Core, and unblock the weekly Rails upgrade.

@adrianna-chang-shopify adrianna-chang-shopify requested review from miry and a team May 1, 2023 15:59
@miry
Copy link
Contributor

miry commented May 2, 2023

Should #491 included in this version?

@jenshenny
Copy link
Contributor

We're intending to! #491 would block the weekly Rails upgrade if it wasn't a part of this release

@adrianna-chang-shopify
Copy link
Contributor Author

Yes, thank you, I wrote up a comment that we needed to wait for it, but didn't actually post it 🤦‍♀️ I'll rebase this with your changes Jenny!

@miry
Copy link
Contributor

miry commented May 2, 2023

@adrianna-chang-shopify Can you also add a note in Changelog about #491 .

@adrianna-chang-shopify adrianna-chang-shopify merged commit c6f5208 into master May 2, 2023
43 checks passed
@adrianna-chang-shopify adrianna-chang-shopify deleted the ac-v1.18.1 branch May 2, 2023 14:22
@miry
Copy link
Contributor

miry commented May 2, 2023

@miry miry changed the title Release v1.18.1 Release v0.18.1 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants