AR Trilogy Adapter: Handle AdapterTimeout and ConnectionFailed errs #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
force-pushed
the
ac-resource-exceptions
branch
from
725c5ad
to
78ed7f7
Compare
casperisfine
approved these changes
Jun 1, 2023
This commit ensures that ActiveRecord::AdapterTimeout errors are handled for the AR Trilogy Adapter. As of rails/rails@785f656, TimeoutErrors are translated to AdapterTimeout errors in Rails. As such, we no longer need special handling in `#acquire_semian_resource` for such errors. This commit also ensures that ActiveRecord::ConnectionFailed errors are classified as resource exceptions. These are network-related exceptions and should be handled by Semian.
adrianna-chang-shopify
force-pushed
the
ac-resource-exceptions
branch
from
78ed7f7
to
121a194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #497
This PR ensures that
ActiveRecord::AdapterTimeouterrors are handled for the AR Trilogy Adapter. As of rails/rails@785f656, TimeoutErrors are translated to AdapterTimeout errors in Rails. As such, we no longer need special handling in#acquire_semian_resourcefor such errors.This commit also ensures that ActiveRecord::ConnectionFailed errors are classified as resource exceptions. These are network-related exceptions and should be handled by Semian. I've added a corresponding test.
cc @casperisfine @etiennebarrie