Fix Rubocop violations

.rubocop.yml

@@ -1,5 +1,3 @@
-inherit_from: .rubocop_todo.yml
-
 AllCops:
   Exclude:
     - tmp/*
@@ -42,6 +40,11 @@ Lint/RescueException:
   Exclude:
     - app/models/shipit/task_execution_strategy/default.rb
 
+Lint/MissingCopEnableDirective:
+  Exclude:
+    - 'lib/shipit/stack_commands.rb'
+    - 'lib/shipit/task_commands.rb'
+
 Lint/SuppressedException:
   Enabled: false
 
@@ -64,5 +67,31 @@ Style/WordArray:
 Style/SymbolArray:
   Enabled: false
 
+Style/ClassMethodsDefinitions:
+  Exclude:
+    - 'app/models/shipit/commit.rb'
+    - 'app/models/shipit/deploy.rb'
+    - 'app/models/shipit/merge_request.rb'
+    - 'app/models/shipit/repository.rb'
+    - 'app/models/shipit/review_stack.rb'
+    - 'app/models/shipit/review_stack_provisioning_queue.rb'
+    - 'app/models/shipit/stack.rb'
+    - 'app/models/shipit/task.rb'
+    - 'app/models/shipit/user.rb'
+    - 'app/models/shipit/webhooks/handlers/handler.rb'
+    - 'lib/shipit/simple_message_verifier.rb'
+    - 'test/models/shipit/stack_test.rb'
+    - 'test/unit/shipit_deployment_checks_test.rb'
+
+Style/OpenStructUse:
+  Exclude:
+    - 'test/jobs/update_github_last_deployed_ref_job_test.rb'
+    - 'test/models/commits_test.rb'
+    - 'test/models/shipit/check_run_test.rb'
+    - 'test/models/shipit/webhooks/handlers/pull_request/review_stack_adapter_test.rb'
+    - 'test/models/status_test.rb'
+    - 'test/unit/github_app_test.rb'
+    - 'test/unit/github_apps_test.rb'
+
 Naming/InclusiveLanguage:
   Enabled: false

Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

app/controllers/concerns/shipit/active_model_serializers_patch.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module ActiveModelSerializersPatch
     private

app/controllers/concerns/shipit/api/cacheable.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     module Cacheable

app/controllers/concerns/shipit/api/paginable.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     module Paginable

app/controllers/concerns/shipit/api/rendering.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     module Rendering

app/controllers/concerns/shipit/authentication.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Authentication
     extend ActiveSupport::Concern

app/controllers/concerns/shipit/pagination.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Pagination
     extend ActiveSupport::Concern

app/controllers/shipit/api/base_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class BaseController < ActionController::Base
@@ -54,6 +55,7 @@ def authenticate_api_client
           end
         end
         return if @current_api_client
+
         headers['WWW-Authenticate'] = 'Basic realm="Authentication token"'
         render(status: :unauthorized, json: { message: 'Bad credentials' })
       end

app/controllers/shipit/api/ccmenu_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class CCMenuController < BaseController

app/controllers/shipit/api/commits_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class CommitsController < BaseController

app/controllers/shipit/api/deploys_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class DeploysController < BaseController
@@ -21,8 +22,13 @@ def create
         param_error!(:require_ci, "Commit is not deployable") if params.require_ci && !commit.deployable?
 
         allow_concurrency = params.allow_concurrency.nil? ? params.force : params.allow_concurrency
-        deploy = stack.trigger_deploy(commit, current_user, env: params.env, force: params.force,
-          allow_concurrency: allow_concurrency)
+        deploy = stack.trigger_deploy(
+          commit,
+          current_user,
+          env: params.env,
+          force: params.force,
+          allow_concurrency: allow_concurrency,
+        )
         render_resource(deploy, status: :accepted)
       end
     end

app/controllers/shipit/api/hooks_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class HooksController < BaseController
@@ -15,7 +16,7 @@ def show
 
       params do
         requires :delivery_url, String
-        requires :events, Array[String]
+        requires :events, [String]
         accepts :content_type, String
       end
       def create
@@ -24,7 +25,7 @@ def create
 
       params do
         accepts :delivery_url, String
-        accepts :events, Array[String]
+        accepts :events, [String]
         accepts :content_type, String
       end
       def update

app/controllers/shipit/api/locks_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class LocksController < BaseController

app/controllers/shipit/api/merge_requests_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class MergeRequestsController < BaseController

app/controllers/shipit/api/outputs_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class OutputsController < BaseController

app/controllers/shipit/api/release_statuses_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class ReleaseStatusesController < BaseController

app/controllers/shipit/api/rollbacks_controller.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Shipit
   module Api
     class RollbacksController < BaseController