Better Multi-CI UI #406
Merged
Better Multi-CI UI #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bigger popover with details of all the checks - Removed black tooltip for grouped status
|
Can you provide a screenshot please? |
|
@gmalette Sure! Success:
Error & Failure:
Pending:
It's not perfect for the error and failure states (well, neither for the others to be honest), but it's a start. We'd probably need "bolder" icons for the smaller versions. They're a bit difficult to see. |
|
That's awesome! |
|
Yep, definitely great! Just tell us when you think it's good and we'll merge! |
|
As discussed outside of this thread, this is still worthy of a few minor improvements like making the icons bolder and adjusting colors. But I's already a huge improvement over #373 so I'll merge it in and continue work there. |
|
Thanks a lot @jeromegn ! |
| @@ -1,4 +1,4 @@ | |||
| <a class="status status--<%= status.state %> <%= :disabled unless status.target_url.present? %>" data-tooltip="<%= status.description.presence || status.state.capitalize %>" href="<%= status.target_url%>" target="_blank"> | |||
| <a class="status status--<%= status.state %> <%= :disabled unless status.target_url.present? %>" <% unless status.group? %>data-tooltip="<%= status.description.presence || status.state.capitalize %>"<% end %> href="<%= status.target_url%>" target="_blank"> | |||
There was a problem hiding this comment.
There is a lot of logic on this line. Maybe it is worth to extract it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: