Implement an API to trigger custom tasks #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_json 'status', 'pending' | ||
| end | ||
|
|
||
| test "#trigger when the task doesn't exist" do |
There was a problem hiding this comment.
#trigger returns a 404 when the task doesn't exist
|
|
||
| def trigger | ||
| render_resource stack.trigger_task(params[:task_name], current_user), status: :accepted | ||
| end |
There was a problem hiding this comment.
We might want to update the require_permission call for TasksController as trigger is more then a :read on :stack.
There was a problem hiding this comment.
:s very good point /o\
|
Aside from the permissions issue LGTM |
|
I've restricted it to |
|
👍 |
byroot
added a commit
that referenced
this pull request
Jul 2, 2015
Implement an API to trigger custom tasks
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #363
Requested by @dwradcliffe
Endpoint
POST /api/stacks/:organization/:repository/:environment/task/:task_namee.g:
POST /api/shopify/shipit/production/task/restart.@gmalette @davidcornu @dwradcliffe for review please.