Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yarn deployments should not hang #642

Merged
merged 1 commit into from Feb 1, 2017
Merged

Yarn deployments should not hang #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/shipit/deploy_spec/npm_discovery.rb
View file
Open in desktop
Expand Up @@ -62,7 +62,8 @@ def discover_deploy_steps

def publish_npm_package
check_tags = 'assert-npm-version-tag'
publish = js_command('publish')
# `yarn publish` requires user input, so always use npm.
publish = 'npm publish'

[check_tags, publish]
end
Expand Down
4 changes: 2 additions & 2 deletions test/unit/deploy_spec_test.rb
View file
Open in desktop
Expand Up @@ -495,9 +495,9 @@ class DeploySpecTest < ActiveSupport::TestCase
assert_equal ['yarn install --no-progress'], @spec.dependencies_steps
end

test '#publish_yarn_package checks if version tag exists, and then invokes yarn publish script' do
test '#publish_yarn_package checks if version tag exists, and then invokes npm publish script' do
@spec.stubs(:yarn?).returns(true).at_least_once
assert_equal ['assert-npm-version-tag', 'yarn publish'], @spec.deploy_steps
assert_equal ['assert-npm-version-tag', 'npm publish'], @spec.deploy_steps
end

test 'yarn checklist takes precedence over npm checklist' do
Expand Down