Use previous rollback behaviour when no previous deploy is found to roll back to. #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackTLi
reviewed
Jul 2, 2019
ajshepley
force-pushed
the
ajs/restrict_previous_deploy_check_by_stack
branch
from
933f3f6
to
2f9124f
Compare
JackTLi
approved these changes
Jul 2, 2019
DazWorrall
approved these changes
Jul 3, 2019
ajshepley
changed the title
…e's no previous deploy. Also provide short_sha method for the NoDeployCommit facsimile.
ajshepley
force-pushed
the
ajs/restrict_previous_deploy_check_by_stack
branch
from
f6f3423
to
c64bebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #913, the Abort&Rollback button (eventually Deploy.trigger_revert) would try to skip unsuccessful tasks when searching for a commit to roll back to, and fix a bug where interleaved stack deploys would be used for the revert sha instead of the same stack.
Unfortunately, an edge case (no prior deploys found) was missed, resulting in a rare but blocking error.
This PR fixes the above problem by deferring to the old rollback behaviour whenever a previous-deploy could not be found. At the same time, I've made sure that the SHA shown in the button will be correct (showing the
current_deploy_task.until_commitin the aforementioned scenario).For context, see also:
#910
#913