Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Version 2019-07 pagination #595

Closed
bgmat opened this issue Jul 5, 2019 · 3 comments
Closed

API Version 2019-07 pagination #595

bgmat opened this issue Jul 5, 2019 · 3 comments

Comments

@bgmat
Copy link

bgmat commented Jul 5, 2019

Hi,

The 2019-07 API version changed the pagination for few resources as described here.

The Product is one of the resources impacted.
I don't see any Breaking change notice, but I think it should be, because the 'page' parameter no longer works and returns an error.

Also, it would be nice to know if you plan to release API support for this feature.

Thank you

@jiri-hacmac
Copy link

Hi,
this feature has already been implemented and merged into master with #594
Great work @garethson 👍
Why is the cursor based pagination targeted to the unstable API version?
As already mentioned some endpoints support this pagination already since 2019-07.
It would be great to to get this feature into a release soon.

@garethson
Copy link
Contributor

@jiri-hacmac Thanks! I've since updated the readme (see #599) to denote that relative cursor navigation is now available on all endpoints using the 2019-10 and later API versions.

Since only some of the endpoints were available in Shopify on 2019-07, we didn't want to add partial support in this library, but now that every endpoint is available, you can simply use 2019-10 (or unstable, which is not recommended for production use).

@garethson
Copy link
Contributor

Closing this issue, but feel free to drop in any questions regarding this library's support for this type pagination here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants