Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full URL and schemeless URL when register HTTP webhooks as usual #1004

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

hoppergee
Copy link
Contributor

@hoppergee hoppergee commented Aug 9, 2022

Description

Make ShopifyAPI::Webhooks::Registry.add_registration to support below 3 types of webhook url config:

  • "test-webhooks"
  • "app-address.com/test-webhooks"
  • "https://app-address.com/test-webhooks"

Otherwise, it may cause shopify_app gem create a wrong callback URL like https://app-address.com/https://app-address.com/test-webhooks with below config:

ShopifyApp.configure do |config|
  config.webhooks = [
    {topic: 'app/uninstalled', address: "https://app-address.com/test-webhooks", format: 'json'},
  ]
end

All developers trying to migrate to shopify_app v20 may meet this issue.

@hoppergee hoppergee requested a review from a team as a code owner August 9, 2022 13:07
@mkevinosullivan
Copy link
Contributor

Please add a entry to the CHANGELOG.md file documenting the change.

@hoppergee hoppergee force-pushed the http_webhook_registration_fix branch from 00f0610 to 5b62d61 Compare August 16, 2022 02:05
@hoppergee hoppergee force-pushed the http_webhook_registration_fix branch from 5b62d61 to 9051d0b Compare August 16, 2022 02:11
Copy link
Contributor

@mkevinosullivan mkevinosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight adjustment to the changelog entry and it's good to merge! Thank you for the contribution, as it adds flexibility to the webhooks configuration.

CHANGELOG.md Outdated Show resolved Hide resolved
@mkevinosullivan mkevinosullivan merged commit bed77e4 into Shopify:main Sep 16, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems October 4, 2022 13:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants