Add extra type to errors for override #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
May 9, 2023
DiscountCode has an errors property that overrides the same property in Base.rb, creating a Sorbet type conflict. This commit adds the additional typing to allow the override. Co-authored-by: Paulo Margarido <64600052+paulomarg@users.noreply.github.com>
mkevinosullivan
force-pushed
the
kos/fix_base_errors_property_types
branch
from
49d2e26
to
125b693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DiscountCodehas anerrorsproperty that overrides the same property inbase.rb, creating a Sorbet type conflict. This commit adds the additional typing to allow the override.How has this been tested?
Re-running the rest wrapper tests.
Checklist:
I have added a changelog line.