Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documents for deprecated session_storage #1165

Merged
merged 1 commit into from
May 29, 2023

Conversation

takp
Copy link
Contributor

@takp takp commented May 27, 2023

Documents for ShopifyAPI::Context.setup is outdated. Due to #1055, configuring the API with session_storage is now deprecated.

Configuring the API with session_storage is now deprecated.
Shopify#1055
@takp
Copy link
Contributor Author

takp commented May 27, 2023

I've signed the CLA

Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch :)

@paulomarg paulomarg merged commit de60fe0 into Shopify:main May 29, 2023
4 checks passed
@takp takp deleted the fix-docs-for-context-setup branch May 30, 2023 05:58
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems July 11, 2023 18:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants