REST resource API rate limit information #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using rest resources there was no way to access the rate limit info This was because we do not allow direct access to the headers Add relevant rate limit info to rest resource as instance vars
lizkenyon
force-pushed
the
liz/rest-resource-rate-limit
branch
2 times, most recently
from
29a764c
to
a76ad14
Compare
lizkenyon
force-pushed
the
liz/rest-resource-rate-limit
branch
from
484d086
to
5c112aa
Compare
lizkenyon
changed the title
lizkenyon
commented
Dec 19, 2023
| @@ -6,20 +6,22 @@ | |||
| ######################################################################################################################## | |||
|
|
|||
| module ShopifyAPI | |||
| class GiftCardAdjustment < ShopifyAPI::Rest::Base | |||
| class Giftcardadjustment < ShopifyAPI::Rest::Base | |||
There was a problem hiding this comment.
I wonder if this change was intentional?
nelsonwittwer
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the REST resources there is currently no way to access the rate limit information
Description
Fixes #1218
Please, include a summary of what the PR is for:
Commit for adding resources
api_call_limitwhich is a hash with the header information fromX-Shopify-Shop-Api-Call-Limitretry_request_afterwhich is the header information fromRetry-AfterCommit for fixing flacky test
With this PR we uncovered several flaky tests, because to of the way they were updating context. We went with the easiest solution for now and set the context back to original after the test completes.
Commit for regenerating REST resources
Because some tests in the test suite use real resources instead of
FakeResourcewe need to regenerate the REST resources to have the new variables for them to pass.Commit for Docs
How has this been tested?
Please, describe the tests that you ran to verify your changes.
Checklist: