Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom_apps.md #1299

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Update custom_apps.md #1299

merged 2 commits into from
Apr 1, 2024

Conversation

jordanschau
Copy link
Contributor

@jordanschau jordanschau commented Mar 29, 2024 •
edited
Loading

Small typo - missing commas

Description

Fixes a small typo in the docs

Please, include a summary of what the PR is for:

  • What is the problem it is solving?
  • What is the context of these changes?
  • What is the impact of this PR?

How has this been tested?

Please, describe the tests that you ran to verify your changes.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@jordanschau
Update custom_apps.md
3226a0f 
Small typo - missing commas
@jordanschau jordanschau requested a review from a team as a code owner March 29, 2024 21:58
sle-c
sle-c approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the updates, could you sign the CLA so we can merge this PR?

@jordanschau
Copy link
Contributor Author

I have signed the CLA!

@paulomarg paulomarg merged commit 0d6ad53 into Shopify:main Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sle-c sle-c sle-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jordanschau @sle-c @paulomarg