Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Registry: Ensuring that the response body is always a Hash, even if ShopifyAPI.Context.response_as_struct is true. #1313

Merged

Commits on Apr 17, 2024

  1. Fixes Shopify#1311 by ensuring that the response body is always a Has…

    …h, even if ShopifyAPI.Context.response_as_struct is true.
    
    Had to add a Utility (ShopifyAPI::Utils::OstructHashUtils) to handle the conversion since a simple .to_h and even JSON.parse(response.body.to_json) did not work as expected (nested Keys and Array handling failed).
    DaveEshopGuide committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    34c8511 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Removed OStructHashUtils Utility Class.

    Added response_as_struct as param to client query to be able to override the default behavior and passed in false for all calls from the webhook registry.
    DaveEshopGuide committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    cdd07a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd158f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Configuration menu
    Copy the full SHA
    6c5496f View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/fix/registry-process-with-respon…

    …se-as-struct' into fix/registry-process-with-response-as-struct
    DaveEshopGuide committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5f6587f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    cef707d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60baf35 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    d8a2e8c View commit details
    Browse the repository at this point in the history