Add new SessionUtil method to retrieve current session Id from Shopify ID token #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzooeeyy
force-pushed
the
support-id-token
branch
from
2006e37
to
3ed00c4
Compare
paulomarg
approved these changes
Apr 18, 2024
rachel-carvalho
approved these changes
Apr 18, 2024
|
|
||
| assert_equal( | ||
| expected_session_id, | ||
| ShopifyAPI::Utils::SessionUtils.current_session_id(@auth_header, nil, false), |
There was a problem hiding this comment.
I know it's not new code we added in this PR, but can we expect to raise the missing JWT error when a valid token is present in the header but doesn't follow the Bearer {token} format?
zzooeeyy
force-pushed
the
support-id-token
branch
from
27de2f3
to
8ab3841
Compare
zzooeeyy
force-pushed
the
support-id-token
branch
from
8ab3841
to
11cbcae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please, include a summary of what the PR is for:
current_session_idexpects an "auth_header" that has format -Bearer id_token, extracted the logic to retrieve the current session ID from justid_tokenfor supporting id token in URL paramImpact
current_session_idwill not be affected, behaviour remained the same.How has this been tested?
Checklist: