Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging for release 7.1.0 #613

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Packaging for release 7.1.0 #613

merged 2 commits into from
Aug 29, 2019

Conversation

DrewMartin
Copy link
Contributor

To include #611

@jtgrenz
Copy link
Contributor

jtgrenz commented Aug 29, 2019

theres a few other PRs that were pending final review, so might be better to wait for those. I had #600 and #605 that just got a final look and need to be rebased. I'll merge those now this morning if you wanna roll them all up together.

Edit: Scratch that. #600 will probably need a bump to 8.0. #605 could go in either one though.

@DrewMartin
Copy link
Contributor Author

Sure thing. Should they be included in the release notes as well?

@jtgrenz
Copy link
Contributor

jtgrenz commented Aug 29, 2019

for 605, maybe just add

ShopifyAPI::Base.api_version now defaults to ShopifyAPI::ApiVersion::NullVersion instead of nil. Making requests without first setting an ApiVersion raises ApiVersionNotSetError instead of NoMethodError: undefined method 'construct_api_path' for nil:NilClass'

or something. Just waiting on CI for that one

@DrewMartin
Copy link
Contributor Author

Updated to include note for #605. Talked to @jtgrenz and #600 will go out separately, probably with a major version bump

@DrewMartin DrewMartin merged commit c8f02c0 into master Aug 29, 2019
@DrewMartin DrewMartin deleted the release-7.1.0 branch August 29, 2019 21:37
@DrewMartin DrewMartin temporarily deployed to rubygems August 29, 2019 22:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants