Bugfix/encode decode activeresource versions #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐑 |
|
|
costford
added a commit
that referenced
this pull request
Oct 29, 2013
…ce_versions Bugfix/encode decode activeresource versions
mkevinosullivan
pushed a commit
that referenced
this pull request
Mar 8, 2022
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) from 0.5.9338 to 0.5.9363. - [Release notes](https://github.com/sorbet/sorbet/releases) - [Commits](https://github.com/sorbet/sorbet/commits) --- updated-dependencies: - dependency-name: sorbet-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Rokas <michael.rokas@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@csaunders @maartenvg
Setting
include_root_in_jsonto true turned out to be problematic for ActiveResource version 3.2, so I yanked 3.1.1. This reinstates the encode/decode/as_json overrides pretty much to the way they were in 3.0.3 with the exception that the decode override is only necessary for ActiveResource 3.0. The other change is that the encode/as_json overrides are scoped to ShopifyAPI::Base rather than ActiveRecord::Base so we don't tromp expectations from other gems.Original PR is #67 for reference.