Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Session#== #714

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Implement Session#== #714

merged 1 commit into from
Apr 15, 2020

Conversation

ragalie
Copy link
Contributor

@ragalie ragalie commented Apr 9, 2020 •
edited
Loading

It's convenient to be able to compare Session objects (when testing, for example).

Co-authored with @gbossh

For: Shopify/shopify_app#951

@ragalie ragalie requested a review from a team as a code owner April 9, 2020 20:32
@ragalie ragalie self-assigned this Apr 9, 2020
tanema
tanema approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@tanema tanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ragalie ragalie merged commit 3e4b5b1 into master Apr 15, 2020
@ragalie ragalie deleted the session-implements-equality branch April 15, 2020 13:36
@ragalie ragalie requested a deployment to rubygems April 15, 2020 15:41 Abandoned
@ragalie ragalie temporarily deployed to rubygems April 15, 2020 15:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanema tanema tanema approved these changes

@emmack emmack emmack approved these changes

@alexaitken alexaitken Awaiting requested review from alexaitken

@gbossh gbossh Awaiting requested review from gbossh

Assignees

@ragalie ragalie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ragalie @tanema @emmack