Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdminVersions module name #927

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

paulomarg
Copy link
Contributor

Description

Fixes #913

The admin_versions file was incorrectly set up, and ended up breaking backward compatibility by dropping the module name.

To make sure this doesn't break any existing apps, as well as to continue providing a shorthand, I aliased the values in the module to the global one as well.

Props to @scart88 for picking this up!

How has this been tested?

Via the unit tests.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added a changelog line.

@paulomarg paulomarg merged commit 7703c5e into main Apr 11, 2022
@paulomarg paulomarg deleted the fix_admin_version_module_name branch April 11, 2022 16:55
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems April 11, 2022 17:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot eager load in Rails 6 from uninitialized constant ShopifyAPI::AdminVersions
2 participants