Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Dashboard missing Admin Performance data #253

Closed
fairknowe opened this issue Nov 22, 2023 · 18 comments
Closed

Partner Dashboard missing Admin Performance data #253

fairknowe opened this issue Nov 22, 2023 · 18 comments
Labels
bug Something isn't working

Comments

@fairknowe
Copy link

Describe the bug

The last date admin performance data for my app appeared was Nov 6. I understand this was due to a bug that was apparently fixed, but I am still not getting data. I haven't found any solutions in existing issues or in the Partner Community forums.

Admin Performance data missing

Packages and versions

@shopify/app-bridge @ 3.7.9 is loaded by <script src="https://unpkg.com/@shopify/app-bridge@3" nonce="<%= request.content_security_policy_nonce %>"></script> in my app/views/layouts/authenticated.html.erb file.
shopify_app (21.7.0) and shopify_api (13.3.0) are loaded as Gems

Platform

  • OS: MacOS, Windows
  • OS Version: 13.6.1
  • App: Admin embedded

Additional context

I'm using Rails 7.1
I am not using React on the front-end. Instead I'm using a vanilla HTML with CSS/Polaris stying, and Hotwire.

My App is still under development and is being loaded only in development stores.

@fairknowe fairknowe added the bug Something isn't working label Nov 22, 2023
@daviareias
Copy link

#273

I've been complaining about this to support for the past 6 months and there's no solution, just keep sending message to support until they fix it.

@fairknowe
Copy link
Author

Update

I now load app-bridge (v4?) by:

<meta name="shopify-api-key" content="<%= ShopifyApp.configuration.api_key %>">

<script src="https://cdn.shopify.com/shopifycloud/app-bridge.js" nonce="<%= request.content_security_policy_nonce %>">
</script>

The shopify_app gem is now at v (21.10.0).

I still don't have any APP Admin performance stats in my dev stores.

@neoanic
Copy link

neoanic commented Feb 22, 2024

I've encountered a similar issue where the performance metrics are no longer reported in the admin performance dashboards after switching to the CDN version of App Bridge last December. I'm using Next.js 14, the latest version of React, and Shopify version 2024-01. Interestingly, while the App Bridge performance metrics have ceased, my Vercel Speed Insights are functioning normally.

Has there been any progress on this issue, or could anyone provide insights into potential workarounds? This is particularly critical as I am in the process of preparing my app for review.

@neoanic
Copy link

neoanic commented Mar 13, 2024

CleanShot 2024-03-13 at 17 50 51@2x

Any updates on this issue? I still don't have any performance statistics in the partner dashboard.
Using the latest App Bridge (CDN Version)

@neoanic
Copy link

neoanic commented Mar 18, 2024

Update: Three days ago, we successfully published our app. As of today, I've observed that the performance data is accessible once more. It's unclear whether this improvement is due to changes within the app bridge or if it's a direct consequence of the app's publication.

@fairknowe
Copy link
Author

Good to know, thanks for the update.

@henrytao-me
Copy link
Member

@fairknowe @neoanic we just pushed a fix in App Bridge CDN. May I have your appId to try it out? Action items:

  • From our team:
    • Have your appIds to turn on the new fix
  • From your team:
    • Make sure you have App Bridge CDN in your app. No other action required

@JoaoGabrielAlves
Copy link

JoaoGabrielAlves commented Mar 22, 2024

Hello @henrytao-me. I am developing an app with the most recent shopify cdn ("https://cdn.shopify.com/shopifycloud/app-bridge.js"), vite, react and laravel.

That is my vite.config.js

import laravel from 'laravel-vite-plugin';
import react from '@vitejs/plugin-react';

export default defineConfig({
    plugins: [
        laravel({
            input: [
                'resources/js/Index.tsx',
                'resources/css/app_block_style.css',
            ],
            refresh: true,
        }),
        react(),
    ],
    css: {
        preprocessorOptions: {
            less: {
                javascriptEnabled: true,
            },
        },
    },
    resolve: {
        preserveSymlinks: true,
    },
    reporters: ['default'],
});

Web vitals seems to be working as expected and there is no data on our admin dashboard as well. I took a look on this issue other github issue #193 but we are not using create-react-app. Do you have any idea why the admin dashboard is not receiving data?

App id: 73649127425

@henrytao-me
Copy link
Member

@JoaoGabrielAlves I can see your dashboard is empty while the webVitals events do send to the server. I am investigating right now. Are you okay to opt-in to a new WebVitals fix?

@JoaoGabrielAlves
Copy link

For sure @henrytao-me. Feel free to apply those possible fixes!

@henrytao-me
Copy link
Member

@JoaoGabrielAlves I confirmed the issue and forwarded to data team to investigate. I will keep you posted about missing performance metrics.

@JoaoGabrielAlves
Copy link

Thank you @henrytao-me !

@cdossantos15
Copy link

Hi @henrytao-me, we are moving our app from a standalone app to an embedded app and are experiencing this as well -- using the CDN version of AppBridge with React and Node (without using create-react-app). App ID: 1178253
We've temporarily disabled app embedding, but still do not see metrics when we toggle embedding to true.

@henrytao-me
Copy link
Member

Hi @cdossantos15, I do see metrics being logged in data pipeline but it don't show up in partner dashboard. I will forward to data team to check your app too 🙇

@scart88
Copy link

scart88 commented Mar 30, 2024

We have been experiencing the same issue for the past week.

It looks like the problem was fixed today. We have missing data between March 23 and March 28

Anyway, I'm glad the issue is fixed now.

@henrytao-me
Copy link
Member

henrytao-me commented Apr 24, 2024

Updates on this:

Let me know if there are any other cases to investigate 🙇

@daviareias
Copy link

* Apps that have less than 100 load times per month won't have BFS badge.

This is not true, you need at least 1000 loads per month in my calculation, because app bridge is not recording most of sessions.

We had 200 installations last month and you can see there's a huge disparity between FID and LCP recording:
Screen Shot 2024-04-25 at 14 45 59
Screen Shot 2024-04-25 at 14 49 38
Screen Shot 2024-04-25 at 14 50 06
Screen Shot 2024-04-25 at 14 53 57
Screen Shot 2024-04-25 at 14 54 04

@wissem
Copy link

wissem commented Jun 4, 2024

hey @henrytao-me, we are also running into a similar issue. We are moving from a standalone app to an embedded app, we use @shopify/app-bridge-react version 3.7.7 and react 18.
There are no web-vitals error on the console. Nothing is being reported under Admin Performance (LCP, CLS, FID are all empty.) We have waited for a few weeks now and have been openning the app multiple times per day.

My testing App ID: 5005323
Could you please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants