fix: storage-[mysql,postgresql] SSL param name

Shopify · Sep 12, 2023 · f3ee4ab · f3ee4ab
1 parent 95e5eae
commit f3ee4ab
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/packages/shopify-app-session-storage-mysql/src/__tests__/mysql.test.ts b/packages/shopify-app-session-storage-mysql/src/__tests__/mysql.test.ts
@@ -137,7 +137,7 @@ describe('MySQLSessionStorage', () => {
 
   it(`can successfully connect with a url string and ssl param`, async () => {
     const _dbURL = new URL(dbURL);
-    _dbURL.searchParams.append('ssl', 'true');
+    _dbURL.searchParams.append('sslMode', 'DISABLED');
     const storage = new MySQLSessionStorage(_dbURL.toString());
     await storage.ready;
     const session = new Session({

diff --git a/packages/shopify-app-session-storage-mysql/src/mysql-connection.ts b/packages/shopify-app-session-storage-mysql/src/mysql-connection.ts
@@ -104,7 +104,8 @@ export class MySqlConnection implements RdbmsConnection {
       database: this.getDatabase(),
       port: Number(this.dbUrl.port),
       ssl: {
-        rejectUnauthorized: this.dbUrl.searchParams.get('ssl') === 'true',
+        rejectUnauthorized:
+          this.dbUrl.searchParams.get('sslMode') === 'DISABLED',
       },
     });
   }

diff --git a/packages/shopify-app-session-storage-postgresql/src/__tests__/postgresql.test.ts b/packages/shopify-app-session-storage-postgresql/src/__tests__/postgresql.test.ts
@@ -136,7 +136,7 @@ describe('PostgreSQLSessionStorage', () => {
 
   it(`can successfully connect with a url string and ssl param`, async () => {
     const _dbURL = new URL(dbURL);
-    _dbURL.searchParams.append('ssl', 'true');
+    _dbURL.searchParams.append('sslmode', 'disable');
     const storage = new PostgreSQLSessionStorage(_dbURL.toString());
     await storage.ready;
     const session = new Session({

diff --git a/packages/shopify-app-session-storage-postgresql/src/postgres-connection.ts b/packages/shopify-app-session-storage-postgresql/src/postgres-connection.ts
@@ -89,7 +89,7 @@ export class PostgresConnection implements RdbmsConnection {
       password: decodeURIComponent(this.dbUrl.password),
       database: this.getDatabase(),
       port: Number(this.dbUrl.port),
-      ssl: this.dbUrl.searchParams.get("ssl") === "true",
+      ssl: this.dbUrl.searchParams.get('sslmode') === 'disable',
     });
   }
 }