[WIP] Add Authenticate storefront app proxy #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
reviewed
Aug 28, 2023
...ges/shopify-app-remix/src/server/authenticate/public/appProxy/__tests__/authenticate.test.ts
Show resolved
Hide resolved
...ges/shopify-app-remix/src/server/authenticate/public/appProxy/__tests__/authenticate.test.ts
Outdated
Show resolved
Hide resolved
packages/shopify-app-remix/src/server/authenticate/public/types.ts
Outdated
Show resolved
Hide resolved
packages/shopify-app-remix/src/server/authenticate/public/types.ts
Outdated
Show resolved
Hide resolved
byrichardpowell
force-pushed
the
authenticate-storefront-app-proxy
branch
2 times, most recently
from
ecb5dfe
to
6ab2ea7
Compare
paulomarg
approved these changes
Sep 1, 2023
packages/shopify-app-remix/src/server/authenticate/public/__tests__/factory.test.ts
Outdated
Show resolved
Hide resolved
packages/shopify-app-remix/src/server/authenticate/public/__tests__/factory.test.ts
Outdated
Show resolved
Hide resolved
...ges/shopify-app-remix/src/server/authenticate/public/appProxy/__tests__/authenticate.test.ts
Outdated
Show resolved
Hide resolved
...ges/shopify-app-remix/src/server/authenticate/public/appProxy/__tests__/authenticate.test.ts
Outdated
Show resolved
Hide resolved
packages/shopify-app-remix/src/server/authenticate/public/types.ts
Outdated
Show resolved
Hide resolved
byrichardpowell
force-pushed
the
authenticate-storefront-app-proxy
branch
from
34199f6
to
f9741f5
Compare
…cts what it will become
…older. The intent is: 1. Make it obvious what test-helpers we have by making them visible in the file system 2. Make it clear where they live (__tests__ is for test files
…all 3 places that we return the admin API client
1. Test a valid request for appProxy 2. Make test for invalid signature more explicit 3. Add comment why we have a suprising type 4. Add TSDoc comments to the authenticate public API
1. Removed .only from two tests (oops) 2. Wrap example titles in <caption> 3. Make it clear in the tests the Request is cross origin 4. app Proxy requests no longer check for a valid session, since that does not seem to be a requirement
… session for that shop
…roxy/types.ts Co-authored-by: Paulo Margarido <64600052+paulomarg@users.noreply.github.com>
byrichardpowell
force-pushed
the
authenticate-storefront-app-proxy
branch
from
0cfe1ca
to
54e10e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Parters need an easy way to authenticate app proxy requests
WHAT is this pull request doing?
authenticate.public.appProxy(request)authenticate.public(request)authenticate.public.checkout(request)to replaceauthenticate.public(request)Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)