-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: shopify-app-session-storage-[mysql,postgresql] to respect SSL DB url param #437
Closed
Closed
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8227320
update: storage-[mysql,postgresql] SSL url param
chr33s db251bf
Merge branch 'Shopify:main' into main
chr33s 6694aec
refactor: ssl to getSSL method
chr33s 81607fb
refactor: shorthand
chr33s d5ec6b7
Merge branch 'Shopify:main' into main
chr33s ef4f7fe
Merge branch 'Shopify:main' into main
chr33s 5d8925d
Merge branch 'main' into main
chr33s 81a90a4
Merge branch 'Shopify:main' into main
chr33s 54150c9
update: session-storage tests to be consistent
chr33s bd30f17
Merge branch 'Shopify:main' into main
chr33s 535ce2d
update: readme to include ssl param in *SessionStorage
chr33s 0d4bfae
fix: tests
chr33s 2676490
Merge branch 'main' into main
lizkenyon eeab97f
Merge branch 'Shopify:main' into main
chr33s a02a946
Merge branch 'Shopify:main' into main
chr33s cdf871d
Merge branch 'Shopify:main' into main
chr33s 564d111
Merge branch 'Shopify:main' into main
chr33s 15088ae
Merge branch 'Shopify:main' into main
chr33s e685631
fix: tests
chr33s bb942b5
Merge branch 'Shopify:main' into main
chr33s 894785b
Merge branch 'Shopify:main' into main
chr33s File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@shopify/shopify-app-session-storage-mysql': patch | ||
'@shopify/shopify-app-session-storage-postgresql': patch | ||
--- | ||
|
||
Update adds support for SSL DB url connection param |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the above database connection URL
this.dbUrl.searchParams.get('ssl')
will return either'{"rejectUnauthorized":true}'
as a string ornull
if not found. I think the!=='false'
check will not work here.I would suggest the following solution :
Ref of
ssl
types:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maruffahmed good catch, will update the pull request.