Update Prisma Adapter to Store User Info for Online Tokens #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizkenyon
force-pushed
the
liz/store-user-info
branch
from
c57ea03
to
743d31b
Compare
lizkenyon
commented
Mar 27, 2024
lizkenyon
changed the title
paulomarg
reviewed
Apr 1, 2024
packages/shopify-app-session-storage-prisma/prisma/schema.prisma
Outdated
Show resolved
Hide resolved
paulomarg
approved these changes
Apr 2, 2024
packages/shopify-app-session-storage-prisma/prisma/schema.prisma
Outdated
Show resolved
Hide resolved
lizkenyon
force-pushed
the
liz/store-user-info
branch
from
81cb62d
to
f2fad99
Compare
lizkenyon
force-pushed
the
liz/store-user-info
branch
from
d2cac45
to
5b9c1a0
Compare
paulomarg
approved these changes
Apr 16, 2024
packages/apps/session-storage/shopify-app-session-storage-prisma/src/prisma.ts
Show resolved
Hide resolved
paulomarg
approved these changes
Apr 17, 2024
paulomarg
approved these changes
May 9, 2024
packages/apps/session-storage/shopify-app-session-storage-prisma/src/prisma.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes find current user
When using online access tokens store all the user info in the Session table to the DB. This data can then be used by the app to implement features such as changing the page based on the user, implementing access controls, and logging users activities.
This PR covers the PRISMA ADAPTER ONLY. We will continue to update the rest of the adapters packages.
WHAT is this pull request doing?
This PR creates a migration for the session table to add in the additional user information received.
For simplicity we decided to store the user information in the session table instead of creating a new user table.
The related prisma functions to store and read from the DB have been updated as well.
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)