[WIP] Add SHOPIFY_API_KEY to DB_PATH when creating database

[mkevinosullivan]

WHY are these changes introduced?

Running the following commands

# create a new app from the Node template
yarn create @shopify/app --template node
# run the app, creating a new app on the partner account
yarn dev

and then opening the provided link will successfully allow the installation of the app.

Doing the following command as a follow-on step

# run the app again, creating a different new app on the partner account
yarn dev --reset

and then opening the provided link will result in a "There's no page at this address" message.

Cause: running the app the second time uses the database.sqlite file created during the first yarn dev, resulting in the error.

WHAT is this pull request doing?

When creating the database file, add the API_KEY in order to differentiate between different instances of the app. The database filename (was database.sqlite) is now db_${API_KEY}.sqlite

[gonzaloriestra]

Thanks! Just two comments:

• I think there are references to database.sqlite in the README.md
• We have to do similar changes in the other templates as well, right?

[paulomarg]

• I think there are references to database.sqlite in the README.md

Good callout - we might have mentions of this in the tutorials as well.

[paulomarg]

LGTM after the points Gonzalo raised!

[gonzaloriestra]

Isn't this ready to be merged?

[mkevinosullivan]

Isn't this ready to be merged?

We haven't merged because we can't do the same implementation across the other templates ... in both the Ruby and PHP templates, the DB must be setup before the first run of yarn dev, as they're managed through Rails or Laravel, respectively.

Hence, we'd end up with an inconsistent experience (there had been a Slack thread on this but it's now long gone)

[gonzaloriestra]

I see, thanks. Any other idea? Does it make sense to try to clear the SQLite database when --reset is run? I know they may use a different database, but I guess we'd cover most cases.

[mkevinosullivan]

Closing this as a terrible idea!