Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tiny typo in README #1217

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix tiny typo in README #1217

merged 1 commit into from
Jan 5, 2023
+1 −1

Conversation

shoheikawano
Copy link
Contributor

@shoheikawano shoheikawano commented Dec 30, 2022 •
edited
Loading

WHY are these changes introduced?

For having better clarity in README

WHAT is this pull request doing?

Fix tiny typo in README

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable

@shoheikawano
Fix tiny typo
b55375b 
npx -> npm
@shoheikawano shoheikawano requested a review from a team as a code owner December 30, 2022 03:33
@shoheikawano
Copy link
Contributor Author

I've signed to CLA so re-running the ci will make the build success

paulomarg
paulomarg approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you

@paulomarg paulomarg merged commit 7e4b704 into Shopify:main Jan 5, 2023
@shoheikawano shoheikawano deleted the patch-1 branch January 7, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shoheikawano @paulomarg