Switch to offline session tokens #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
force-pushed
the
kos/switch_auth_to_offline_tokens
branch
2 times, most recently
from
302b755
to
12d7722
Compare
mkevinosullivan
changed the base branch from
cli_three
to
cli_three_feature_v1_0_0_next
paulomarg
force-pushed
the
kos/switch_auth_to_offline_tokens
branch
from
12d7722
to
c68ed93
Compare
paulomarg
force-pushed
the
kos/switch_auth_to_offline_tokens
branch
2 times, most recently
from
6eec080
to
901317f
Compare
paulomarg
force-pushed
the
kos/switch_auth_to_offline_tokens
branch
from
901317f
to
34ed95f
Compare
paulomarg
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Current guidance is to prefer offline to online session tokens
Closes https://github.com/Shopify/first-party-library-planning/issues/355
WHAT is this pull request doing?
onlinefromtruetofalse/api/products-countto/api/products/count(aligned with change in frontend)/api/products/createendpoint for frontend (FE previously used GraphQL proxy)