Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial laravel commit #1

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Initial laravel commit #1

merged 1 commit into from
Apr 30, 2021

Conversation

MuhammadFarag
Copy link
Contributor

@MuhammadFarag MuhammadFarag commented Apr 29, 2021

Auto generated Laravel project. Follow up PRs would remove the sections of the code that we are not going to use.

  • composer create-project laravel/laravel shopify-app-php
  • Add .idea and .vscode to .gitignore

composer create-project laravel/laravel shopify-app-php

Add .idea and .vscode to .gitignore
@paulomarg
Copy link
Collaborator

We could probably commit this right away and remove things as another PR - that would help unblock getting started on the other tasks involving this repo!

@MuhammadFarag MuhammadFarag marked this pull request as ready for review April 30, 2021 01:50
@MuhammadFarag MuhammadFarag requested a review from a team as a code owner April 30, 2021 01:50
@MuhammadFarag
Copy link
Contributor Author

@paulomarg Sure 👍

@MuhammadFarag MuhammadFarag changed the title [WIP] Initial laravel commit Initial laravel commit Apr 30, 2021
@MuhammadFarag MuhammadFarag merged commit 45826a1 into main Apr 30, 2021
@MuhammadFarag MuhammadFarag deleted the new-laravel-app branch April 30, 2021 13:29
paulomarg added a commit that referenced this pull request Jun 6, 2022
Adapt to CLI 3 and use new FE as submodule
sinarahmany added a commit to sinarahmany/shopify-app-template-php that referenced this pull request Jan 1, 2024
Hey there!

I made a quick update to the README file. If you're installing the app using Shopify CLI with PHP and facing a white page on your dev store, just remember to add "HOST" to your .env file. This should fix the issue.

Happy New Year!


Laravel Log:
Shopify\Utils::sanitizeShopDomain(): Argument Shopify#1 ($shop) must be of type string, null given, called in /home/andrea/projects/shopify/test4/routes/web.php on line 29 {"exception":"[object] (TypeError(code: 0): Shopify\\Utils::sanitizeShopDomain(): Argument Shopify#1 ($shop) must be of type string, null given, called in /home/andrea/projects/shopify/test4/routes/web.php on line 29 at /home/andrea/projects/shopify/test4/vendor/shopify/shopify-api/src/Utils.php:31)
[stacktrace]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants