Use offline tokens #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
use_offline_tokens
branch
2 times, most recently
from
049828d
to
33322d9
Compare
mkevinosullivan
approved these changes
Jul 8, 2022
| @@ -14,7 +14,6 @@ | |||
| config.after_authenticate_job = false | |||
| config.api_version = ShopifyAPI::AdminVersions::LATEST_SUPPORTED_ADMIN_VERSION | |||
| config.shop_session_repository = "Shop" | |||
| config.user_session_repository = "User" | |||
There was a problem hiding this comment.
Will shopify_app work without a configured user session repository?
There was a problem hiding this comment.
yes, as per the docs, adding a user_session_repository is what makes the gem use online tokens.
|
LGTM! 🚢 |
paulomarg
force-pushed
the
use_offline_tokens
branch
from
33322d9
to
6a92afe
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Current guidance is to prefer offline to online session tokens
WHAT is this pull request doing?
shopify_appto use offline tokens (noUsermodel / session repository)/api/products-countto/api/products/count(aligned with change in frontend)/api/products/createendpoint for frontend (FE previously used GraphQL proxy)