This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Rails force generate to include overwritten CSP file #2143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
For context:
Rails apps published in the App Store require the proper Content Security Policy to be set, specifically the frame_ancestors directive. The change in shopify_app accomplishes this by creating a new CSP configuration template with frame_ancestors included. This requires that when running
rails generate ...
, the-f
flag must be passed in so that we can overwrite the default CSP configuration template (content_security_policy.rb).WHAT is this pull request doing?
Adds the
-f
flag to forcibly overwrite the content_security_policy.rb file when generating rails apps.How to test your changes?
Run
shopify app create rails
and verify that the app is generated correctly (ideally with the new csp file).Post-release steps
Update checklist