👍 update for new shopify-express api #95
Conversation
|
I can't 🎩because my I'll try again tomorrow :( |
There was a problem hiding this comment.
Having issues during 🎩where the redirect_uri slashes are being converted?
&redirect_uri=https%3A%2F%2Falexbradley.ngrok.io%2F%2Fshopify%2Fauth%2Fcallback
The readme whitelist URL instruction needs to be changed to the new redirect
Set the whitelisted URL to {{ HOST }}/shopify/auth/callback
|
Ok, thanks, I'll take a look at this again tonight or tommorrow morning |
|
@AWaselnuk @lopert is right that we need to also change the README, so that's probably why your whitelist is wrong. @lopert You're right that the readme needs updating, but I'm not seeing issues with the escaping locally. We should chat about how this is set up for you. For me it works fine with latest |
If you mean this is what appears in your address bar during the OAuth grant screen, this is actually intended. The URI should be escaped since it's being passed as a URL param. Shopify knows that it should unescape it on its side. |
There was a problem hiding this comment.
I fixed my callback URL and the auth dance now works fine.
But we need to update our demo app code to send API calls to the right endpoint. If you load it up and try to use the form to GET /products.json it returns 404 because it looks at /api/products.json. We should be sending requests to /shopify/api/products.json
|
Sidenote: our UI demo is pretty lame - we don't even display a flash or UI message of any kind when you get a |
|
@AWaselnuk updated the URL |
server/shopify.js
Outdated
| afterAuth(request, response) { | ||
| const { session: { accessToken, shop } } = request; | ||
|
|
||
| // registerWebhook(shop, accessToken, { |
There was a problem hiding this comment.
Can we remove these comments + console.log?
marutypes
force-pushed
the
update/shopify-express-callback-url-fix
branch
from
946cd69
to
04c6a63
Compare
Please try this out on your own dev stores :)